srowen commented on a change in pull request #23257: [SPARK-26310][SQL] Verify
applicability of JSON options
URL: https://github.com/apache/spark/pull/23257#discussion_r246113306
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1635,6 +1635,14 @@ object SQLConf {
"java.time.* packages are used for the same purpose.")
.booleanConf
.createWithDefault(false)
+
+ val VERIFY_DATASOURCE_OPTIONS =
buildConf("spark.sql.verifyDataSourceOptions")
Review comment:
OK, I can't say I feel too strongly about it, but when would this be set to
`false` @gatorsmile ? this is a case where the user is already setting useless
options right, so they can a) somehow discover this flag or b) just remove the
options. b) seems much more likely to happen. Is the worry about legacy code or
libraries that can't be easily modified? those already may not work on Spark 3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
