BryanCutler commented on a change in pull request #22807:
[SPARK-25811][PySpark] Raise a proper error when unsafe cast is detected by
PyArrow
URL: https://github.com/apache/spark/pull/22807#discussion_r246215883
##########
File path: python/pyspark/sql/tests.py
##########
@@ -4961,6 +4961,31 @@ def foofoo(x, y):
).collect
)
+ def test_pandas_udf_detect_unsafe_type_conversion(self):
+ from distutils.version import LooseVersion
+ from pyspark.sql.functions import pandas_udf
+ import pandas as pd
+ import numpy as np
+ import pyarrow as pa
+
+ values = [1.0] * 3
+ pdf = pd.DataFrame({'A': values})
+ df = self.spark.createDataFrame(pdf).repartition(1)
+
+ @pandas_udf(returnType="int")
+ def udf(column):
+ return pd.Series(np.linspace(0, 1, 3))
+
+ udf_boolean = df.select(['A']).withColumn('udf', udf('A'))
+
+ # Since 0.11.0, PyArrow supports the feature to raise an error for
unsafe cast.
+ if LooseVersion(pa.__version__) >= LooseVersion("0.11.0"):
Review comment:
I think I was talking about something like an integer overflow. In pyarrow
0.8.0 it will raise an error:
```
In [10]: pa.Array.from_pandas(pd.Series([128]), type=pa.int8())
---------------------------------------------------------------------------
ArrowInvalid Traceback (most recent call last)
<ipython-input-10-49026b548de3> in <module>()
----> 1 pa.Array.from_pandas(pd.Series([128]), type=pa.int8())
...
ArrowInvalid: Integer value out of bounds
```
but in 0.11.1 with `safe=False`, it will allow this
```
In [11]: pa.Array.from_pandas(pd.Series([128]), type=pa.int8(), safe=False)
Out[11]:
<pyarrow.lib.Int8Array object at 0x7f49eebb0f48>
[
-128
]
```
So I think I was saying you could add a test that makes sure the default
behavior is to raise an error on overflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
