cloud-fan commented on a change in pull request #23462: [SPARK-26546][SQL]
Caching of java.time.format.DateTimeFormatter
URL: https://github.com/apache/spark/pull/23462#discussion_r246224499
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -23,9 +23,40 @@ import java.time.format.{DateTimeFormatter,
DateTimeFormatterBuilder, ResolverSt
import java.time.temporal.{ChronoField, TemporalAccessor, TemporalQueries}
import java.util.Locale
+import com.google.common.cache.CacheBuilder
+
+import org.apache.spark.sql.catalyst.util.DateTimeFormatterHelper._
+
trait DateTimeFormatterHelper {
+ protected def toInstantWithZoneId(temporalAccessor: TemporalAccessor,
zoneId: ZoneId): Instant = {
+ val localTime = if (temporalAccessor.query(TemporalQueries.localTime) ==
null) {
+ LocalTime.ofNanoOfDay(0)
+ } else {
+ LocalTime.from(temporalAccessor)
+ }
+ val localDate = LocalDate.from(temporalAccessor)
+ val localDateTime = LocalDateTime.of(localDate, localTime)
+ val zonedDateTime = ZonedDateTime.of(localDateTime, zoneId)
+ Instant.from(zonedDateTime)
+ }
+
+ def getOrCreateFormatter(pattern: String, locale: Locale): DateTimeFormatter
= {
+ val key = (pattern, locale)
+ var formatter = cache.getIfPresent(key)
+ if (formatter == null) {
Review comment:
let's add a comment to say that, we intentionally drop the `synchronized`
here, as the worst case is we create the same formatter more than once, which
doesn't matter.
without the comment, I'm afraid people may open PRs to add the
`synchronized` later, as they don't know the context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
