shaneknapp commented on a change in pull request #23492: [SPARK-26565][BUILD]
skip gpg signing/svn publish for jenkins package builds
URL: https://github.com/apache/spark/pull/23492#discussion_r246224543
##########
File path: dev/create-release/release-build.sh
##########
@@ -314,21 +325,23 @@ if [[ "$1" == "package" ]]; then
rm -rf spark-$SPARK_VERSION-bin-*/
- if ! is_dry_run; then
- svn co --depth=empty $RELEASE_STAGING_LOCATION svn-spark
- rm -rf "svn-spark/${DEST_DIR_NAME}-bin"
- mkdir -p "svn-spark/${DEST_DIR_NAME}-bin"
-
- echo "Copying release tarballs"
- cp spark-* "svn-spark/${DEST_DIR_NAME}-bin/"
- cp pyspark-* "svn-spark/${DEST_DIR_NAME}-bin/"
- cp SparkR_* "svn-spark/${DEST_DIR_NAME}-bin/"
- svn add "svn-spark/${DEST_DIR_NAME}-bin"
-
- cd svn-spark
- svn ci --username $ASF_USERNAME --password "$ASF_PASSWORD" -m"Apache Spark
$SPARK_PACKAGE_VERSION" --no-auth-cache
- cd ..
- rm -rf svn-spark
+ if [ -z "$AMPLAB_JENKINS" ]; then
+ if ! is_dry_run; then
Review comment:
i think this way is much more "clear" as to show what's not being run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]