xuanyuanking commented on a change in pull request #23396: [SPARK-26397][SQL]
Driver side only metrics support
URL: https://github.com/apache/spark/pull/23396#discussion_r246266400
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
##########
@@ -552,11 +552,13 @@ class SQLMetricsSuite extends SparkFunSuite with
SQLMetricsTestUtils with Shared
// The execution plan only has 1 FileScan node.
val df = spark.sql(
"SELECT * FROM testDataForScan WHERE p = 1")
- testSparkPlanMetrics(df, 1, Map(
Review comment:
Yep, actually the changing
[here](https://github.com/apache/spark/pull/23396/files#diff-dc5c7a41fbb7479cef48b67eb41ad254R56)
has made `testSparkPlanMetrics` able to check drvierMetrisc, I'll revert the
changes here. Done in 10df5b1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
