viirya commented on a change in pull request #23457: [SPARK-26539][CORE] Remove spark.memory.useLegacyMode and StaticMemoryManager URL: https://github.com/apache/spark/pull/23457#discussion_r246274198
########## File path: core/src/main/scala/org/apache/spark/memory/package.scala ########## @@ -61,15 +61,10 @@ package org.apache.spark * }}} * * - * There are two implementations of [[org.apache.spark.memory.MemoryManager]] which vary in how - * they handle the sizing of their memory pools: + * There is one implementation of [[org.apache.spark.memory.MemoryManager]]: * * - [[org.apache.spark.memory.UnifiedMemoryManager]], the default in Spark 1.6+, enforces soft Review comment: nit: since just one implementation now, still need to mention this is default? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
