felixcheung commented on a change in pull request #23492: [SPARK-26565][BUILD]
skip gpg signing/svn publish for jenkins package builds
URL: https://github.com/apache/spark/pull/23492#discussion_r246285414
##########
File path: dev/create-release/release-build.sh
##########
@@ -235,40 +240,46 @@ if [[ "$1" == "package" ]]; then
-DzincPort=$ZINC_PORT 2>&1 > ../binary-release-$NAME.log
cd ..
- if [[ -n $R_FLAG ]]; then
- echo "Copying and signing R source package"
- R_DIST_NAME=SparkR_$SPARK_VERSION.tar.gz
- cp spark-$SPARK_VERSION-bin-$NAME/R/$R_DIST_NAME .
-
- echo $GPG_PASSPHRASE | $GPG --passphrase-fd 0 --armour \
- --output $R_DIST_NAME.asc \
- --detach-sig $R_DIST_NAME
- echo $GPG_PASSPHRASE | $GPG --passphrase-fd 0 --print-md \
- SHA512 $R_DIST_NAME > \
- $R_DIST_NAME.sha512
+ if [ -z "$AMPLAB_JENKINS" ]; then
+ if [[ -n $R_FLAG ]]; then
+ echo "Copying and signing R source package"
+ R_DIST_NAME=SparkR_$SPARK_VERSION.tar.gz
+ cp spark-$SPARK_VERSION-bin-$NAME/R/$R_DIST_NAME .
+
+ echo $GPG_PASSPHRASE | $GPG --passphrase-fd 0 --armour \
Review comment:
I'd flip this though? I think we should need to copy but just not sign -
otherwise the R and python package might not be saved from the build?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
