maropu commented on a change in pull request #23456: [SPARK-26538][SQL] Set
default precision and scale for elements of po…
URL: https://github.com/apache/spark/pull/23456#discussion_r246327130
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala
##########
@@ -60,7 +60,12 @@ private object PostgresDialect extends JdbcDialect {
case "bytea" => Some(BinaryType)
case "timestamp" | "timestamptz" | "time" | "timetz" => Some(TimestampType)
case "date" => Some(DateType)
- case "numeric" | "decimal" => Some(DecimalType.bounded(precision, scale))
+ case "numeric" | "decimal" => if (precision > 0) {
Review comment:
I would like to confirm just in case; we don't check `scale` in this pr?
Probably, this might be related to the discussion:
https://github.com/apache/spark/pull/23458#discussion_r245480257
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
