peter-toth commented on a change in pull request #22617: [SPARK-25484][SQL][TEST] Refactor ExternalAppendOnlyUnsafeRowArrayBenchmark URL: https://github.com/apache/spark/pull/22617#discussion_r246349011
########## File path: sql/core/benchmarks/ExternalAppendOnlyUnsafeRowArrayBenchmark-results.txt ########## @@ -0,0 +1,50 @@ +================================================================================================ +WITHOUT SPILL +================================================================================================ + +Java HotSpot(TM) 64-Bit Server VM 1.8.0_162-b12 on Mac OS X 10.13.6 +Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz + +Array with 100000 rows: Best/Avg Time(ms) Rate(M/s) Per Row(ns) Relative +------------------------------------------------------------------------------------------------ +ArrayBuffer 4810 / 5120 21.3 47.0 1.0X +ExternalAppendOnlyUnsafeRowArray 4996 / 5043 20.5 48.8 1.0X + +Java HotSpot(TM) 64-Bit Server VM 1.8.0_162-b12 on Mac OS X 10.13.6 +Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz + +Array with 1000 rows: Best/Avg Time(ms) Rate(M/s) Per Row(ns) Relative +------------------------------------------------------------------------------------------------ +ArrayBuffer 8839 / 8951 29.7 33.7 1.0X +ExternalAppendOnlyUnsafeRowArray 9884 / 9888 26.5 37.7 0.9X Review comment: Got the same ratio as you have this time: ``` [info] Java HotSpot(TM) 64-Bit Server VM 1.8.0_162-b12 on Mac OS X 10.13.6 [info] Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz [info] Array with 1000 rows: Best/Avg Time(ms) Rate(M/s) Per Row(ns) Relative [info] ------------------------------------------------------------------------------------------------ [info] ArrayBuffer 10028 / 10197 26.1 38.3 1.0X [info] ExternalAppendOnlyUnsafeRowArray 30053 / 30312 8.7 114.6 0.3X ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
