cloud-fan commented on a change in pull request #23383: [SPARK-23817][SQL] Migrate ORC file format read path to data source V2 URL: https://github.com/apache/spark/pull/23383#discussion_r246375321
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ########## @@ -213,6 +215,23 @@ case class DataSourceAnalysis(conf: SQLConf) extends Rule[LogicalPlan] with Cast } } +/** + * Replace the V2 data source of table in [[InsertIntoTable]] to V1 [[FileFormat]]. + * E.g, with temporary view `t` using [[FileDataSourceV2]], inserting into view `t` fails + * since there is no correspoding physical plan. + * This is a temporary hack for making current data source V2 work. It should be removed + * when catalog of data source v2 is finished. Review comment: this is not about catalog. If we are inserting to a table, the `FindDataSourceTable` rule already does the fallback by calling `providingClass`. This rule only handles inserting to temp view, which needs the data source to implement write API. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
