jamisonbennett commented on a change in pull request #23398: [SPARK-26493][SQL]
Allow multiple spark.sql.extensions
URL: https://github.com/apache/spark/pull/23398#discussion_r246383290
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala
##########
@@ -151,14 +241,63 @@ case class MyParser(spark: SparkSession, delegate:
ParserInterface) extends Pars
object MyExtensions {
val myFunction = (FunctionIdentifier("myFunction"),
- new ExpressionInfo("noClass", "myDb", "myFunction", "usage", "extended
usage" ),
+ new ExpressionInfo("noClass", "myDb", "myFunction", "usage", "extended
usage"),
(myArgs: Seq[Expression]) => Literal(5, IntegerType))
+
}
class MyExtensions extends (SparkSessionExtensions => Unit) {
def apply(e: SparkSessionExtensions): Unit = {
e.injectPlannerStrategy(MySparkStrategy)
e.injectResolutionRule(MyRule)
+ e.injectPostHocResolutionRule(MyRule)
+ e.injectCheckRule(MyCheckRule)
+ e.injectOptimizerRule(MyRule)
+ e.injectParser(MyParser)
e.injectFunction(MyExtensions.myFunction)
}
}
+
+case class MyRule2(spark: SparkSession) extends Rule[LogicalPlan] {
+ override def apply(plan: LogicalPlan): LogicalPlan = plan
+}
+
+case class MyCheckRule2(spark: SparkSession) extends (LogicalPlan => Unit) {
+ override def apply(plan: LogicalPlan): Unit = { }
+}
+
+case class MySparkStrategy2(spark: SparkSession) extends SparkStrategy {
+ override def apply(plan: LogicalPlan): Seq[SparkPlan] = Seq.empty
+}
+
+object MyExtensions2 {
+
+ val myFunction = (FunctionIdentifier("myFunction2"),
+ new ExpressionInfo("noClass", "myDb", "myFunction2", "usage", "extended
usage" ),
+ (_: Seq[Expression]) => Literal(5, IntegerType))
+}
+
+class MyExtensions2 extends (SparkSessionExtensions => Unit) {
+ def apply(e: SparkSessionExtensions): Unit = {
+ e.injectPlannerStrategy(MySparkStrategy2)
+ e.injectResolutionRule(MyRule2)
+ e.injectPostHocResolutionRule(MyRule2)
+ e.injectCheckRule(MyCheckRule2)
+ e.injectOptimizerRule(MyRule2)
+ e.injectParser((_, _) => CatalystSqlParser)
+ e.injectFunction(MyExtensions2.myFunction)
+ }
+}
+
+object MyExtensions2Duplicate {
+
+ val myFunction = (FunctionIdentifier("myFunction2"),
+ new ExpressionInfo("noClass", "myDb", "myFunction2", "usage", "last wins"
),
Review comment:
I made both changes and also updated one of the tests to validate the
`ExpressionInfo` object rather than the extended usage text.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
