srowen commented on a change in pull request #23502: [SPARK-22128][CORE][BUILD] Add `paranamer` dependency to `core` module URL: https://github.com/apache/spark/pull/23502#discussion_r246591279
########## File path: core/pom.xml ########## @@ -33,6 +33,11 @@ <name>Spark Project Core</name> <url>http://spark.apache.org/</url> <dependencies> + <dependency> + <groupId>com.thoughtworks.paranamer</groupId> Review comment: I see, so we need to make sure to include paranamer, as it won't work if it inherits an older one at runtime? This is OK. I would change this slightly; you don't need to include `<version>` here as that's managed in the parent POM. And in the parent, you can declare this as `<scope>runtime</scope>` I suppose, because it's not directly used, but it won't matter much. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
