Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3470#issuecomment-65157328
I think this is probably a reasonable semantic to have given keywords are
not generally case sensitive in SQL, but I think that we need to add some
documentation to `DataSource` that says that this is the case. You might even
go so far as to provide a case insensitive map to avoid confusion when
developers try to do lookups with keywords that contain capital letters.
thoughts @liancheng @rxin?
Also, given the current implementation, I would just statically lowercase
samplingRatio instead of using toLower.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
