srowen commented on a change in pull request #23499: [SPARK-26254][CORE] 
Extract Hive + Kafka dependencies from Core.
URL: https://github.com/apache/spark/pull/23499#discussion_r246799620
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -101,6 +101,7 @@
     <module>examples</module>
     <module>repl</module>
     <module>launcher</module>
+    <module>external/kafka-0-10-token-provider</module>
 
 Review comment:
   From the JIRA it sounds like a new module is unfortunately the best way to 
clean this up, so OK. It can't live in the kafka-0-10 module, because non-Kafka 
things need it? I'm wondering, because of the name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to