dongjoon-hyun commented on a change in pull request #23383: [SPARK-23817][SQL] 
Migrate ORC file format read path to data source V2
URL: https://github.com/apache/spark/pull/23383#discussion_r246854790
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
 ##########
 @@ -82,7 +82,7 @@ class OrcFileFormat
   with DataSourceRegister
   with Serializable {
 
-  override def shortName(): String = "orc"
+  override def shortName(): String = "orcV1"
 
 Review comment:
   Then, let's keep the original~ Like you, I also tried renaming when I split 
`native`/`hive` ORC implementation. The feedback was negative.  I believe DSv2 
migration plan is not intended to touch this of DSv1.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to