jzhuge commented on a change in pull request #23507: [SPARK-26576][SQL]
Broadcast hint not applied to partitioned table
URL: https://github.com/apache/spark/pull/23507#discussion_r246988507
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitions.scala
##########
@@ -71,7 +71,13 @@ private[sql] object PruneFileSourcePartitions extends
Rule[LogicalPlan] {
// Keep partition-pruning predicates so that they are visible in
physical planning
val filterExpression = filters.reduceLeft(And)
val filter = Filter(filterExpression, prunedLogicalRelation)
- Project(projects, filter)
+ op match {
+ case h: ResolvedHint =>
Review comment:
I have tried this fix, it works. However, I am not sure about the original
rational to add this code in SPARK-14581, and trying to minimize the impact of
removing it because there are other callers of PhysicalOperation.unapply.
If @davies and @cloud-fan are ok and we can pass test cases covering the
scenarios for this code, I'd be happy to go with this fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
