viirya commented on a change in pull request #23510: [SPARK-26590][CORE] make
fetch-block-to-disk backward compatible
URL: https://github.com/apache/spark/pull/23510#discussion_r247016413
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
##########
@@ -128,11 +128,15 @@ public void setClientId(String id) {
* be agreed upon by client and server beforehand.
* @param chunkIndex 0-based index of the chunk to fetch
* @param callback Callback invoked upon successful receipt of chunk, or
upon any failure.
+ * @param streamCallback If it's not null, we will send a
`ChunkFetchRequest` with
+ * `fetchAsStream=true`, and this callback will be
used to handle the stream
+ * response.
*/
public void fetchChunk(
Review comment:
Not big deal but maybe rename to `fetchChunkOrStream`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
