mgaido91 commented on a change in pull request #23456: [SPARK-26538][SQL] Set
default precision and scale for elements of postgres numeric array
URL: https://github.com/apache/spark/pull/23456#discussion_r247056797
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala
##########
@@ -60,7 +60,12 @@ private object PostgresDialect extends JdbcDialect {
case "bytea" => Some(BinaryType)
case "timestamp" | "timestamptz" | "time" | "timetz" => Some(TimestampType)
case "date" => Some(DateType)
- case "numeric" | "decimal" => Some(DecimalType.bounded(precision, scale))
+ case "numeric" | "decimal" => if (precision > 0) {
Review comment:
if we'd add `|| scale > 0`, we'd allow a percision <= 0,which doesn't make
any sense and it is not supported by Spark's decimal. So I think this is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
