SongYadong commented on issue #23497: [SPARK-26578][CORE] Synchronize putBytes's memory allocation and putting block on memoryManager URL: https://github.com/apache/spark/pull/23497#issuecomment-453497565 I'm sorry, I haven't found actual problem. I think it may be better that acquiring memory and putting block to LinkHashMap work together as an atomic operation. Could this avoid some data inconsistency? Nested synchronized here may not cause deadlock beacuse they synchronize on the same lock. If this cause deadlock, `MemoryStore.remove()`, `MemoryStore.clear()`, `MemoryStore.reserveUnrollMemoryForThisTask()`, `MemoryStore.releaseUnrollMemoryForThisTask()` have the same problem.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
