cloud-fan commented on a change in pull request #23510: [SPARK-26590][CORE]
make fetch-block-to-disk backward compatible
URL: https://github.com/apache/spark/pull/23510#discussion_r247101454
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/client/TransportResponseHandler.java
##########
@@ -112,6 +119,13 @@ private void failOutstandingRequests(Throwable cause) {
logger.warn("ChunkReceivedCallback.onFailure throws exception", e);
}
}
+ for (Map.Entry<StreamChunkId, StreamCallback> entry :
outstandingFetchAsStreams.entrySet()) {
+ try {
+ entry.getValue().onFailure(entry.getKey().toString(), cause);
+ } catch (Exception e) {
+ logger.warn("ChunkReceivedCallback.onFailure throws exception", e);
Review comment:
These 2 callbacks are individual, we only need to take care one of them, and
discard the other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
