srowen commented on a change in pull request #23488: [SPARK-26564] Fix wrong
assertions and error messages for parameter checking
URL: https://github.com/apache/spark/pull/23488#discussion_r247135938
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -413,7 +413,7 @@ private[execution] final class LongToUnsafeRowMap(val mm:
TaskMemoryManager, cap
private def init(): Unit = {
if (mm != null) {
- require(capacity < 512000000, "Cannot broadcast more than 512 millions
rows")
+ require(capacity <= 512000000, "Cannot broadcast more than 512 millions
rows")
Review comment:
Ah, good catch. Sorry @sekikn could we change this one more time, to use `<`
and then fix the error message instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
