viirya commented on a change in pull request #23521: [SPARK-26604][CORE]
Register channel for stream request
URL: https://github.com/apache/spark/pull/23521#discussion_r247294659
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
##########
@@ -127,6 +127,7 @@ private void processStreamRequest(final StreamRequest req)
{
ManagedBuffer buf;
try {
buf = streamManager.openStream(req.streamId);
+ streamManager.registerChannel(channel, req.streamId);
Review comment:
For stream request and get chunk request, they are recorded in stream
manager. Registering channel for them is to make sure they are removed from
stream manager when the channel is inactive. For other types of requests, I
don't find they are recorded like that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
