viirya commented on a change in pull request #20146: [SPARK-11215][ML] Add 
multiple columns support to StringIndexer
URL: https://github.com/apache/spark/pull/20146#discussion_r247329790
 
 

 ##########
 File path: R/pkg/tests/fulltests/test_mllib_regression.R
 ##########
 @@ -102,10 +102,18 @@ test_that("spark.glm and predict", {
 })
 
 test_that("spark.glm summary", {
+  # prepare dataset
 
 Review comment:
   Here I handcrafted tiny dataset (8 rows) to replace iris dataset (150 rows). 
Because iris dataset contains a column which has frequently equal string values 
(50 times for 3 strings) and we can't config R's string indexer, it makes 
trouble to produce same results for this test.
   
   There are few discussions 
https://github.com/apache/spark/pull/20146#issuecomment-355764569 for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to