jzhuge commented on a change in pull request #23530: [SPARK-26576][SQL]
Broadcast hint not applied to partitioned table
URL: https://github.com/apache/spark/pull/23530#discussion_r247333601
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
##########
@@ -68,9 +68,6 @@ object PhysicalOperation extends PredicateHelper {
val substitutedCondition = substitute(aliases)(condition)
(fields, filters ++ splitConjunctivePredicates(substitutedCondition),
other, aliases)
- case h: ResolvedHint =>
- collectProjectsAndFilters(h.child)
-
Review comment:
Yeah, it is safer to only port the unit test. However, we believe this is
dead code, otherwise we might have to revisit the fix for 2.4 and 2.3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
