srowen commented on a change in pull request #22282: [SPARK-23539][SS] Add
support for Kafka headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#discussion_r247349287
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaRelationSuite.scala
##########
@@ -71,7 +71,13 @@ class KafkaRelationSuite extends QueryTest with
SharedSQLContext with KafkaTest
withOptions.foreach {
case (key, value) => df.option(key, value)
}
- df.load().selectExpr("CAST(value AS STRING)")
+ if (!includeHeaders) {
Review comment:
Very small suggestion: flip the if condition to avoid the negation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
