imatiach-msft commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision trees URL: https://github.com/apache/spark/pull/21632#issuecomment-453899345 @srowen thank you for taking another look at the PR. I think I have addressed most comments except for two of them. For one of them, I'm not sure how I could handle the MIMA exclusion, I assume that I need to define another constructor without the new parameter but I am getting duplicate method errors. For the other, I just need some clarification - you mentioned mllib should not point to ml but in this case it indeed does not, since there are two LabeledPoint classes, one in mllib and the other (which was the one modified) in ml. I've suggested two ways to fix the issue but both seem sub-optimal to me. Would like to know your thoughts on this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
