yucai commented on a change in pull request #19788: [SPARK-9853][Core] Optimize
shuffle fetch of contiguous partition IDs
URL: https://github.com/apache/spark/pull/19788#discussion_r247396423
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockFetchingListener.java
##########
@@ -27,7 +27,7 @@
* automatically. If the data will be passed to another thread, the receiver
should retain()
* and release() the buffer on their own, or copy the data to a new buffer.
*/
- void onBlockFetchSuccess(String blockId, ManagedBuffer data);
+ void onBlockFetchSuccess(String[] blockIds, ManagedBuffer data);
Review comment:
Current implementation is easier and when failure, Spark will report all
remaining blocks (including still fetching), it is not so meaningful, upper
layer does not use this information also.
Do you think we have to?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
