GitHub user maji2014 opened a pull request:
https://github.com/apache/spark/pull/3553
[spark-4691][shuffle]code optimization for judgement
In HashShuffleReader.scala and HashShuffleWriter.scala, no need to judge
"dep.aggregator.isEmpty" again as this is judged by "dep.aggregator.isDefined"
In SortShuffleWriter.scala, "dep.aggregator.isEmpty" is better than
"!dep.aggregator.isDefined" ?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maji2014/spark spark-4691
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3553.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3553
----
commit d8f52dc7dc34bc6c1c368d790b7bdfe30c4eb529
Author: maji2014 <[email protected]>
Date: 2014-12-02T09:54:33Z
code optimization for judgement
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
