srowen commented on a change in pull request #23412: [SPARK-26477][CORE] Use
ConfigEntry for hardcoded configs for unsafe category
URL: https://github.com/apache/spark/pull/23412#discussion_r247537355
##########
File path:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java
##########
@@ -59,21 +60,22 @@ public UnsafeSorterSpillReader(
File file,
BlockId blockId) throws IOException {
assert (file.length() > 0);
+ final ConfigEntry<Object> bufferSizeConfigEntry =
+ package$.MODULE$.UNSAFE_SORTER_SPILL_READER_BUFFER_SIZE();
Review comment:
This can't be `ConfigEntry<Long>` because the Scala side has the generic
type as a `long`? It seems like it ends up a `Long` anyway as you're able to
`.get()` and cast it to `long`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
