peter-toth commented on a change in pull request #23531: [SPARK-24497][SQL]
Support recursive SQL query
URL: https://github.com/apache/spark/pull/23531#discussion_r247552872
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -289,13 +294,13 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
extends Product {
/**
* Returns a copy of this node where `f` has been applied to all the nodes
children.
*/
- def mapChildren(f: BaseType => BaseType): BaseType = {
- if (children.nonEmpty) {
+ def mapChildren(f: BaseType => BaseType, forceCopy: Boolean = false):
BaseType = {
Review comment:
You are right @mgaido91, `BroadcastExchangeExec` and similar nodes cause
some issues there. We can't prepare them until we have the result of the
previous iteration (or the result of the anchor). This is why I introduced
`doNotPrepareInAdvance`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
