rdblue commented on a change in pull request #21978: [SPARK-25006][SQL] Add
CatalogTableIdentifier.
URL: https://github.com/apache/spark/pull/21978#discussion_r247597895
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala
##########
@@ -18,30 +18,32 @@
package org.apache.spark.sql.catalyst
/**
- * An identifier that optionally specifies a database.
+ * An identifier that optionally specifies a database and catalog.
*
* Format (unquoted): "name" or "db.name"
* Format (quoted): "`name`" or "`db`.`name`"
*/
-sealed trait IdentifierWithDatabase {
+sealed trait IdentifierWithOptionalDatabaseAndCatalog {
val identifier: String
def database: Option[String]
+ def catalog: Option[String]
Review comment:
This is an abstract method definition and catalog is always implemented by a
val.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
