Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3550#issuecomment-65264098
Yeah, this seems safe to me. Even if the Master doesn't know that the
driver has exited for some reason (i.e. if the `finishApplication` was somehow
not triggered from the `DisassociatedEvent`
[here](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/deploy/master/Master.scala#L411)),
this will still fail the application correctly because all existing executors
will have exited and new executors will fail immediately because they can't
connect to the driver. I agree that this is a better fix for 1.2. Eventually it
would be good to get Josh's changes in too because it's easier to test things
there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
