HyukjinKwon commented on a change in pull request #23519: [SPARK-26601][SQL]
Make broadcast-exchange thread pool configurable
URL: https://github.com/apache/spark/pull/23519#discussion_r247748426
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala
##########
@@ -126,4 +126,10 @@ object StaticSQLConf {
.intConf
.createWithDefault(1000)
+ val MAX_BROADCAST_EXCHANGE_THREADNUMBER =
+ buildStaticConf("spark.sql.broadcastExchange.maxThreadNumber")
+ .doc("MAX number of threads can hold by BroadcastExchangeExec which
controls" +
Review comment:
Still, users won't know what's `BroadcastExchangeExec` and `MAX number of
threads`. Please do your diligence for this doc. Also, we might have to
describe when to increase and when to decrease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
