cloud-fan commented on a change in pull request #23396: [SPARK-26397][SQL]
Driver side only metrics support
URL: https://github.com/apache/spark/pull/23396#discussion_r247765214
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -167,26 +167,17 @@ case class FileSourceScanExec(
partitionSchema = relation.partitionSchema,
relation.sparkSession.sessionState.conf)
- val driverMetrics: HashMap[String, Long] = HashMap.empty
-
- /**
- * Send the driver-side metrics. Before calling this function,
selectedPartitions has
- * been initialized. See SPARK-26327 for more details.
- */
- private def sendDriverMetrics(): Unit = {
- driverMetrics.foreach(e => metrics(e._1).add(e._2))
- val executionId =
sparkContext.getLocalProperty(SQLExecution.EXECUTION_ID_KEY)
- SQLMetrics.postDriverMetricUpdates(sparkContext, executionId,
- metrics.filter(e => driverMetrics.contains(e._1)).values.toSeq)
- }
+ driverMetrics ++=
+ Map("numFiles" -> SQLMetrics.createMetric(sparkContext, "number of files"),
+ "metadataTime" -> SQLMetrics.createMetric(sparkContext, "metadata time
(ms)"))
Review comment:
sorry for the back and forth. After thinking about it more, I think it's
safer to update `driverMetrics` inside `selectedPartitions`, so that it's lazy
as before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
