attilapiros edited a comment on issue #23540: [SPARK-26615][Core] Fixing 
transport server/client resource leaks in the core unittests
URL: https://github.com/apache/spark/pull/23540#issuecomment-454287636
 
 
   @squito There is no more leaks I found in core (regarding 
TransportClient/Server). When we talked I just missed some cleanup made in 
afterEach/afterAll (my first logging for checking the number of created/closed 
instances was only in org.apache.spark.SparkFunSuite#withFixture).
   
   Regarding ThreadAudit I cannot say (making the tests longer is something we 
should avoid but I do not know whether that time would be relevant comparing to 
the whole). 
   
   I am very curious is this already helps for @NiharS at 
https://github.com/apache/spark/pull/22114.
   What about making his change here waiting for Jenkins to test it and then 
removing that commit?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to