HyukjinKwon commented on a change in pull request #20691: [SPARK-18161] [Python] Allow pickle to serialize >4 GB objects when possible (Python 3.4+) URL: https://github.com/apache/spark/pull/20691#discussion_r247847071
########## File path: python/pyspark/cloudpickle.py ########## @@ -852,11 +853,11 @@ def _rebuild_tornado_coroutine(func): # Shorthands for legacy support -def dump(obj, file, protocol=2): +def dump(obj, file, protocol=protocol): Review comment: @inpefess, I was actually meaning upgrade cloudpickle to upper version see https://github.com/apache/spark/pull/21350. Our copy is matched to 0.4.4 for now. The main reason we stayed in 0.4.x was that the default pickle protocol was changed as of 0.5.x. Since we're targeting to upgrade it here, It should be good to match cloudpickle copy to higher version, rather then changing the protocol in cloudpickle alone. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
