maropu commented on a change in pull request #23551: [SPARK-26622] Revise SQL
Metrics labels
URL: https://github.com/apache/spark/pull/23551#discussion_r247852399
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/UnsafeFixedWidthAggregationMap.java
##########
@@ -226,10 +226,10 @@ public void free() {
}
/**
- * Gets the average hash map probe per looking up for the underlying
`BytesToBytesMap`.
+ * Gets the collision rate per looking up for the underlying
`BytesToBytesMap`.
*/
- public double getAverageProbesPerLookup() {
- return map.getAverageProbesPerLookup();
+ public double getHashCollisionsPerLookup() {
+ return map.getAverageProbesPerLookup() - 1.0;
Review comment:
Why `- 1.0` here? This change is different from the description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
