juliuszsompolski commented on a change in pull request #23551:
[SPARK-26622][SQL] Revise SQL Metrics labels
URL: https://github.com/apache/spark/pull/23551#discussion_r247863525
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/UnsafeFixedWidthAggregationMap.java
##########
@@ -226,10 +226,10 @@ public void free() {
}
/**
- * Gets the average hash map probe per looking up for the underlying
`BytesToBytesMap`.
+ * Gets the collision rate per looking up for the underlying
`BytesToBytesMap`.
*/
- public double getAverageProbesPerLookup() {
- return map.getAverageProbesPerLookup();
+ public double getHashCollisionsPerLookup() {
+ return map.getAverageProbesPerLookup() - 1.0;
Review comment:
Edit: "avg hash probe bucket list iterations", because that's exactly what
it is...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
