gengliangwang commented on a change in pull request #23551: [SPARK-26622][SQL]
Revise SQL Metrics labels
URL: https://github.com/apache/spark/pull/23551#discussion_r247940994
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
##########
@@ -63,8 +63,9 @@ case class HashAggregateExec(
"numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of output
rows"),
"peakMemory" -> SQLMetrics.createSizeMetric(sparkContext, "peak memory"),
"spillSize" -> SQLMetrics.createSizeMetric(sparkContext, "spill size"),
- "aggTime" -> SQLMetrics.createTimingMetric(sparkContext, "aggregate time"),
- "avgHashProbe" -> SQLMetrics.createAverageMetric(sparkContext, "avg hash
probe"))
+ "aggTime" -> SQLMetrics.createTimingMetric(sparkContext, "time in
aggregation build"),
+ "avgHashProbe" ->
+ SQLMetrics.createAverageMetric(sparkContext, "avg hash probe bucket list
iterations"))
Review comment:
No big deal but `avg hash probe bucket list iterations` seems a bit long,
can we make it briefe? It also affects the method name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
