srowen commented on a change in pull request #23552:
[DO-NOT-MERGE][SPARK-23710] Upgrade built-in Hive to 2.3.4(Without
hive-thriftserver)
URL: https://github.com/apache/spark/pull/23552#discussion_r247984489
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala
##########
@@ -253,6 +253,12 @@ private[hive] trait SaveAsHiveFile extends
DataWritingCommand {
dir
}
+ private def isSubDir(p1: Path, p2: Path, fs: FileSystem): Boolean = {
+ val path1 = fs.makeQualified(p1).toString
+ val path2 = fs.makeQualified(p2).toString
+ if (path1.startsWith(path2)) true else false
Review comment:
No need for `if (...) true else false`. Just return the value of the
predicate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
