dongjoon-hyun commented on a change in pull request #23553: [SPARK-23710][SQL] 
Upgrade built-in Hive to 2.3.4
URL: https://github.com/apache/spark/pull/23553#discussion_r248004106
 
 

 ##########
 File path: sql/core/pom.xml
 ##########
 @@ -86,15 +86,17 @@
       <scope>test</scope>
     </dependency>
 
+    <dependency>
+      <groupId>org.apache.hive</groupId>
+      <artifactId>hive-storage-api</artifactId>
+    </dependency>
 
 Review comment:
   Hi, @wangyum . This PR does lots of things, so it's great.
   But, we should not have `hive` dependency in `sql/core` module.
   This blocks independent ORC version upgrades. ORC should be upgrade 
independently like Parquet.
   This is the same comment from the original PR. And, it becomes more 
important because we are using Hive 2 instead of Hive 3.
   
   cc @gatorsmile , @cloud-fan , @rxin 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to