dbtsai commented on a change in pull request #23542: [WIP] [SPARK-25603][SQL]
Pushing Down Nested Field projections
URL: https://github.com/apache/spark/pull/23542#discussion_r248095908
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -611,6 +611,29 @@ object ColumnPruning extends Rule[LogicalPlan] {
// Can't prune the columns on LeafNode
case p @ Project(_, _: LeafNode) => p
+ // If the current project or the child references to nested fields, we can
substitute them
Review comment:
I feel it should be part of `ColumnPruning`.
Do you mean move this particular rule out or move the entire `ColumnPruning`
into a new file? If the later, I chatted with @gatorsmile, and he felt moving
the entire `ColumnPruning` out will lost the history which is not ideal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
