wangtao605 commented on a change in pull request #23516: [SPARK-26598] Fix
HiveThriftServer2 set hiveconf and hivevar in every sql
URL: https://github.com/apache/spark/pull/23516#discussion_r248125153
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/server/SparkSQLOperationManager.scala
##########
@@ -51,9 +50,6 @@ private[thriftserver] class SparkSQLOperationManager()
require(sqlContext != null, s"Session handle:
${parentSession.getSessionHandle} has not been" +
s" initialized or had already closed.")
val conf = sqlContext.sessionState.conf
- val hiveSessionState = parentSession.getSessionState
- setConfMap(conf, hiveSessionState.getOverriddenConfigurations)
- setConfMap(conf, hiveSessionState.getHiveVariables)
Review comment:
@gatorsmile sorry, i did not test it's performance. But in code logically,
it could have a little in perf and i perform to removing it to
SparkSQLSessionManager to handle hiveconf and hivevar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
