Ngone51 edited a comment on issue #23355: [SPARK-26418][SHUFFLE] Only 
OpenBlocks without any ChunkFetch for one stream will cause memory leak in 
ExternalShuffleService
URL: https://github.com/apache/spark/pull/23355#issuecomment-454373004
 
 
   ~@cloud-fan It's not same. #23521 register a channel when server receive 
`FetchChunkRequest` or `SreamRequest` after it receiving `OpenBlocks`, which 
follows past way. And this pr suggests to register a channel once server 
receive `OpenBlocks`.~
   
   ~And I think there's conflict now since #23521 try to make `registerChannel` 
a `private` method.~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to