dongjoon-hyun commented on a change in pull request #23412: [SPARK-26477][CORE]
Use ConfigEntry for hardcoded configs for unsafe category
URL: https://github.com/apache/spark/pull/23412#discussion_r248194600
##########
File path:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java
##########
@@ -37,8 +39,7 @@
*/
public final class UnsafeSorterSpillReader extends UnsafeSorterIterator
implements Closeable {
private static final Logger logger =
LoggerFactory.getLogger(UnsafeSorterSpillReader.class);
Review comment:
Since we remove `warn` here, shall we remove the unused lines together?
```java
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
```
```java
- private static final Logger logger =
LoggerFactory.getLogger(UnsafeSorterSpillReader.class);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
