cloud-fan commented on a change in pull request #23383: [SPARK-23817][SQL]
Create file source V2 framework and migrate ORC read path
URL: https://github.com/apache/spark/pull/23383#discussion_r248221122
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
##########
@@ -193,7 +192,16 @@ class DataFrameReader private[sql](sparkSession:
SparkSession) extends Logging {
"read files of Hive data source directly.")
}
- val cls = DataSource.lookupDataSource(source,
sparkSession.sessionState.conf)
+ val disabledV2Readers =
+
sparkSession.sessionState.conf.userV1SourceReaderList.toLowerCase(Locale.ROOT).split(",")
+ val lookupCls = DataSource.lookupDataSource(source,
sparkSession.sessionState.conf)
+ val cls = lookupCls.newInstance() match {
+ case f: FileDataSourceV2 if disabledV2Readers.contains(f.shortName()) ||
Review comment:
shall we lowercase short name as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
