mgaido91 commented on a change in pull request #23562: [SPARK-26619][SQL] Prune
the unused serializers from SerializeFromObject
URL: https://github.com/apache/spark/pull/23562#discussion_r248295668
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -561,6 +561,12 @@ object ColumnPruning extends Rule[LogicalPlan] {
case d @ DeserializeToObject(_, _, child) if
!child.outputSet.subsetOf(d.references) =>
d.copy(child = prunedChild(child, d.references))
+ case p @ Project(_, s: SerializeFromObject) if p.references != s.outputSet
=>
+ val prunedSerializer = s.serializer.filter { expr =>
+ p.references.contains(expr.toAttribute)
Review comment:
I'd just want to avoid regenerating the `p.references` `AttributeSet` for
every expr, which may become expensive if there are a lot of exprs. If
intersect doesn't work, maybe just a:
```
val prunedRefs = p.references
val prunedSerializer = s.serializer.filter(prunedRefs.contains)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
