MaxGekk commented on a change in pull request #23512: [SPARK-26593][SQL] Use
Proleptic Gregorian calendar in casting UTF8String to Date/TimestampType
URL: https://github.com/apache/spark/pull/23512#discussion_r248378624
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
##########
@@ -78,8 +78,8 @@ class DateExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
}
checkEvaluation(DayOfYear(Literal.create(null, DateType)), null)
- checkEvaluation(DayOfYear(Literal(new Date(sdf.parse("1582-10-15
13:10:15").getTime))), 288)
- checkEvaluation(DayOfYear(Literal(new Date(sdf.parse("1582-10-04
13:10:15").getTime))), 277)
+ checkEvaluation(DayOfYear(Cast(Literal("1582-10-15 13:10:15"), DateType)),
288)
Review comment:
I removed it from the suite
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]