maropu commented on a change in pull request #23541: [SPARK-26618][SQL] Make
typed Timestamp/Date literals consistent to casting
URL: https://github.com/apache/spark/pull/23541#discussion_r248519739
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
##########
@@ -680,4 +687,21 @@ class ExpressionParserSuite extends PlanTest {
assertEqual("last(a ignore nulls)", Last('a,
Literal(true)).toAggregateExpression())
assertEqual("last(a)", Last('a, Literal(false)).toAggregateExpression())
}
+
+ test("timestamp literals") {
+ withSQLConf(SQLConf.SESSION_LOCAL_TIMEZONE.key -> "UTC") {
Review comment:
To check if a selected timezone reflected in a parser, how about adding
tests for other timezones?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
