squito commented on a change in pull request #22806: [SPARK-25250][CORE] : Late
zombie task completions handled correctly even before new taskset launched
URL: https://github.com/apache/spark/pull/22806#discussion_r248770953
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
##########
@@ -1319,4 +1328,34 @@ class TaskSchedulerImplSuite extends SparkFunSuite with
LocalSparkContext with B
tsm.handleFailedTask(tsm.taskAttempts.head.head.taskId, TaskState.FAILED,
TaskKilled("test"))
assert(tsm.isZombie)
}
+
+ test("SPARK-25250 On successful completion of a task attempt on a partition
id, kill other" +
Review comment:
This test isn't testing the important case that was missed before, and I
think for now we don't want to kill tasks as part of this change. OTOH, we do
need to take the "Completions in zombie tasksets update status of non-zombie
taskset" test and move it to a test in DAGSchedulerSuite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
